Fancy fraction formatting #386
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mustache0110
force-pushed
the
fancy-fractions
branch
from
757b784
to
48babc5
Compare
|
Font size could be nudged up or down, but current size seems to be a good balance between standing out and legibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 reasons behind this feature:
I dropped in a flexible helper function, but it could be simplified. If @Pseudonian wants to put it directly in format, we can just have the fractional code output .innerHTML code. Then for the few elements that use fractional code, calling DOM('element').innerHTML = format(sometimes fractional number) will work fine when the number is big or small. I'll push this idea as a separate commit, because simpler might be better.
The more complicated change could avoid innerHTML use by showing/hiding a fractional container and setting the numerator and denominator as .textContent. I don't think this is necessary, I'm not sure.